SaurabhChawla100 commented on a change in pull request #32381:
URL: https://github.com/apache/spark/pull/32381#discussion_r624878008
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -192,6 +201,32 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
</a>
</span> ++
<div id="application-timeline" class="collapsed">
+ {
+ if (MAX_TIMELINE_JOBS < jobs.size) {
+ <div>
+ <strong>
+ This page has more than the maximum number of jobs that can be
shown in the
Review comment:
Just thinking -> Shall we have this alert in red colour since this is
one of the scenario where we are showing the limited information
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -118,7 +125,9 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
private def makeExecutorEvent(executors: Seq[v1.ExecutorSummary]):
Seq[String] = {
val events = ListBuffer[String]()
- executors.foreach { e =>
+ executors.sortBy { e =>
+ -math.max(e.addTime.getTime, e.removeTime.map(_.getTime).getOrElse(-1L))
Review comment:
shall we do it in the same way by sorting with both the attributes as
done in case of jobs and stages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
