gengliangwang commented on a change in pull request #32421:
URL: https://github.com/apache/spark/pull/32421#discussion_r625505942
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
##########
@@ -93,4 +94,12 @@ case class LocalRelation(
}
override def maxRows: Option[Long] = Some(data.length.toLong)
+
+ override val nodePatterns: Seq[TreePattern] = {
+ if (this.data.isEmpty) {
Review comment:
shall we just make it `LOCAL_RELATION`?
We can prune `LOCAL_RELATION` in `ConvertToLocalRelation`.
We got general patterns like `BINARY_COMPARISON` and `BINARY_ARITHMETIC`.
This one is very specific and it looks odd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
