sigmod edited a comment on pull request #32425: URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319
> @sigmod Does this include all the analyzer rules? It includes most rules in fixed point batches in those places (because rule id only helps rules that invoke multiple times, e.g., in a fixed point batch): https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292 https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243 https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248 Two rules are currently not included: - TypeCoercionRule which currently does a hand-written recursion; - CTESubstitution which has a slightly complex logic with multiple transform calls. I plan to address them in subsequent PRs. Three rules that rely on potentially changing, external states currently are not included neither: - ResolveTableValuedFunctions(v1SessionCatalog) - ResolveNamespace(catalogManager) - ResolveCatalogs(catalogManager) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
