srowen commented on a change in pull request #32413:
URL: https://github.com/apache/spark/pull/32413#discussion_r626904769
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -236,7 +236,26 @@ case class StaticInvoke(
override def children: Seq[Expression] = arguments
lazy val argClasses = ScalaReflection.expressionJavaClasses(arguments)
- @transient lazy val method = cls.getDeclaredMethod(functionName, argClasses
: _*)
+ @transient lazy val method = {
+ try {
+ cls.getDeclaredMethod(functionName, argClasses: _*)
+ } catch {
+ case _: NoSuchMethodException =>
+ // For some cases, e.g. arg class is Object, `getMethod` cannot find
the method.
+ // We look at function name + argument length
+ val m = cls.getDeclaredMethods.filter { m =>
+ m.getName == functionName && m.getParameterCount == arguments.length
+ }
+ if (m.isEmpty) {
+ sys.error(s"Couldn't find $functionName on $cls")
+ } else if (m.length > 1) {
+ // Ambiguous case, we don't know which method to choose, just fail
it.
+ sys.error(s"Found ${m.length} $functionName on $cls")
+ } else {
+ m.head
Review comment:
I think it's fine to stay conservative for a change you will backport.
This will only cause cases that failed completely to possibly work now, right?
so I think that's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
