dongjoon-hyun commented on a change in pull request #32407:
URL: https://github.com/apache/spark/pull/32407#discussion_r627107997
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ApplyFunctionExpression.scala
##########
@@ -29,11 +29,12 @@ case class ApplyFunctionExpression(
override def name: String = function.name()
override def dataType: DataType = function.resultType()
+ private lazy val childrenWithIndex = children.zipWithIndex
private lazy val reusedRow = new GenericInternalRow(children.size)
/** Returns the result of evaluating this expression on a given input Row */
override def eval(input: InternalRow): Any = {
- children.zipWithIndex.foreach {
+ childrenWithIndex.foreach {
Review comment:
This file change is orthogonal to this PR. Can we split this change as a
separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
