gengliangwang commented on a change in pull request #32381:
URL: https://github.com/apache/spark/pull/32381#discussion_r627534327
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -192,6 +201,32 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
</a>
</span> ++
<div id="application-timeline" class="collapsed">
+ {
+ if (MAX_TIMELINE_JOBS < jobs.size) {
+ <div>
+ <strong>
+ This page has more than the maximum number of jobs that can be
shown in the
+ visualization! Only the most recent {MAX_TIMELINE_JOBS}
submitted/completed jobs
+ (of {jobs.size} total) are shown.
Review comment:
Nit: how about just
```
Only the most recent {MAX_TIMELINE_JOBS} submitted jobs(of {jobs.size}
total) are shown.
```
The sentence
```
This page has more than the maximum number of jobs that can be shown in the
...
```
seems redundant.
Not sure whether we should hint the user to tune the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
