sunchao commented on a change in pull request #32446:
URL: https://github.com/apache/spark/pull/32446#discussion_r627930998
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -303,7 +303,7 @@ private[hive] class HiveClientImpl(
// with the side-effect of Hive.get(conf) to avoid using out-of-date
HiveConf.
// See discussion in
https://github.com/apache/spark/pull/16826/files#r104606859
// for more details.
- Hive.get(conf)
+ shim.getHive(conf)
Review comment:
yeah it shouldn't - both function are doing the same in this case by
updating the `Hive` object's config with provided `conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
