maropu commented on pull request #32457:
URL: https://github.com/apache/spark/pull/32457#issuecomment-834479650


   @kiszk @viirya Yea, you're right; the previous approach seems bad. So, I 
applied two improvements based on your suggestion;
    - Checks if eval code size goes over the limit 
(`spark.sql.codegen.methodSplitThreshold`)
    - Creates a single method  per projection (@viirya suggested above)
   
   Could you check the latest code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to