Ngone51 commented on a change in pull request #32389:
URL: https://github.com/apache/spark/pull/32389#discussion_r628668376
##########
File path:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
##########
@@ -228,117 +272,72 @@ class ShuffleBlockFetcherIteratorSuite extends
SparkFunSuite with PrivateMethodT
when(blockManager.hostLocalDirManager).thenReturn(Some(hostLocalDirManager))
when(mockExternalBlockStoreClient.getHostLocalDirs(any(), any(), any(),
any()))
.thenAnswer { invocation =>
- val completableFuture = invocation.getArguments()(3)
- .asInstanceOf[CompletableFuture[java.util.Map[String,
Array[String]]]]
- completableFuture.completeExceptionally(new Throwable("failed fetch"))
+ invocation.getArgument[CompletableFuture[java.util.Map[String,
Array[String]]]](3)
+ .completeExceptionally(new Throwable("failed fetch"))
}
blockManager.hostLocalDirManager = Some(hostLocalDirManager)
val blocksByAddress = Seq[(BlockManagerId, Seq[(BlockId, Long, Int)])](
(hostLocalBmId, hostLocalBlocks.keys.map(blockId => (blockId, 1L,
1)).toSeq)
).toIterator
Review comment:
Why this not reuse `getBlocksByAddressForSingleBM`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
