c21 commented on a change in pull request #30138:
URL: https://github.com/apache/spark/pull/30138#discussion_r628711441
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanHelper.scala
##########
@@ -139,15 +138,21 @@ trait AdaptiveSparkPlanHelper {
}
/**
- * Returns a cloned [[SparkSession]] with adaptive execution disabled, or
the original
- * [[SparkSession]] if its adaptive execution is already disabled.
+ * Returns a cloned [[SparkSession]] with all specified configurations
disabled, or
+ * the original [[SparkSession]] if all configurations are already disabled.
*/
- def getOrCloneSessionWithAqeOff[T](session: SparkSession): SparkSession = {
- if (!session.sessionState.conf.adaptiveExecutionEnabled) {
+ def getOrCloneSessionWithConfigsOff(
Review comment:
@ulysses-you, @maropu - sorry my bad. This and AQE is for performance
only, but not correctness. Then i am find with either adding or not adding
another config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
