dongjoon-hyun commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r628798552
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
##########
@@ -78,7 +82,17 @@ public static void collectMetric(
new ShuffleServiceMetricsInfo(name + "_rate1", "1 minute rate of
timer " + name),
t.getOneMinuteRate())
.addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean rate
of timer " + name),
- t.getMeanRate());
+ t.getMeanRate())
+ .addGauge(getMetricsInfoGenericValue(timingName, "max"),
snapshot.getMax())
+ .addGauge(getMetricsInfoGenericValue(timingName, "min"),
snapshot.getMin())
+ .addGauge(getMetricsInfoGenericValue(timingName, "mean"),
snapshot.getMean())
+ .addGauge(getMetricsInfoGenericValue(timingName, "stdDev"),
snapshot.getStdDev());
+ for (int percentile : new int[] { 1, 5, 25, 50, 75, 95, 99 }) {
Review comment:
Is there a reason of this selection? In general, we use
`Snapshot.get98thPercentile` and `Snapshot.get999thPercentile` additionally too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
