dongjoon-hyun commented on a change in pull request #31829:
URL: https://github.com/apache/spark/pull/31829#discussion_r628834835
##########
File path:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -176,4 +180,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION
-P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG
-Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes
-Pkubernetes-integration-tests ${properties[@]}
Review comment:
Well, I know that we need `install` sometimes, but for this one, I'm a
little negative for converting `integration-test` to `install` because it
pollutes the local repo while testing and reviewing someone-else's PR. It's
really painful for committers to clean up the local repo everytime to avoid any
side-effects for the other PRs. Is this really inevitable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
