HyukjinKwon commented on a change in pull request #32448:
URL: https://github.com/apache/spark/pull/32448#discussion_r629072673
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala
##########
@@ -707,32 +710,63 @@ class DataFrameSetOperationsSuite extends QueryTest with
SharedSparkSession {
val df2 = Seq((1, UnionClass1c(1, 2L, UnionClass4(2, 3L)))).toDF("id",
"a")
var unionDf = df1.unionByName(df2, true)
- checkAnswer(unionDf,
- Row(0, Row(0, 1, Row(null, 1, null, "2"))) ::
- Row(1, Row(1, 2, Row(2, null, 3L, null))) :: Nil)
assert(unionDf.schema.toDDL ==
"`id` INT,`a` STRUCT<`a`: INT, `b`: BIGINT, " +
- "`nested`: STRUCT<`A`: INT, `a`: INT, `b`: BIGINT, `c`: STRING>>")
+ "`nested`: STRUCT<`a`: INT, `c`: STRING, `A`: INT, `b`: BIGINT>>")
Review comment:
Can we update migration guide
(https://github.com/apache/spark/blob/master/docs/sql-migration-guide.md)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
