Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97845313
@shaneknapp well, to start, I couldn't agree more that something looks very
fishy with `pr_public_classes`. That was a direct port from the previous code
though which makes it even more interesting :/
To address the SHA1 hash its getting pulled from, as I'm sure you know,
[this code
here](https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java#L170)
which, I'll admit, is interesting in and of itself in that it could produce
the SHA1 as an actual hash **or** what we see above (in the case that the patch
can merge without conflict into master).
That said `pr_public_classes` only relies on the `ghprbActualCommit` and
not the SHA1 so unless that were empty somehow I'm not immediately sure how
this could be happening (of which it isn't empty according to Jenkins).
My only thought, and I'm hoping you could shed some light here, would be a
possible race condition from some shared state on each Jenkins box such that
the Bash calls (or environment variables) aren't atomic to the PR they're
building. Thoughts on that? I'll continue to dig and see what I can find.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
