maropu commented on a change in pull request #32455:
URL: https://github.com/apache/spark/pull/32455#discussion_r629746849
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1434,9 +1435,10 @@ object CodeGenerator extends Logging {
private def updateAndGetCompilationStats(evaluator: ClassBodyEvaluator):
ByteCodeStats = {
// First retrieve the generated classes.
val classes = {
- val resultField = classOf[SimpleCompiler].getDeclaredField("result")
- resultField.setAccessible(true)
- val loader =
resultField.get(evaluator).asInstanceOf[ByteArrayClassLoader]
+ val scField = classOf[ClassBodyEvaluator].getDeclaredField("sc")
Review comment:
Is the data the totally same with `ByteArrayClassLoader.classes`? The
suggestion is a trivial update though, IMO this PR just focuses on the janino
upgrade. Could you make a follow-up PR for it after this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
