mridulm commented on a change in pull request #30691:
URL: https://github.com/apache/spark/pull/30691#discussion_r629810563
##########
File path: core/src/main/scala/org/apache/spark/Dependency.scala
##########
@@ -96,12 +96,27 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
val shuffleHandle: ShuffleHandle =
_rdd.context.env.shuffleManager.registerShuffle(
shuffleId, this)
+ // By default, shuffle merge is enabled for ShuffleDependency if push based
shuffle is enabled
+ private[this] var _shuffleMergeEnabled =
Utils.isPushBasedShuffleEnabled(rdd.sparkContext.getConf)
+
+ def setShuffleMergeEnabled(shuffleMergeEnabled: Boolean): Unit = {
Review comment:
`private[spark]` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
