cloud-fan commented on a change in pull request #31756:
URL: https://github.com/apache/spark/pull/31756#discussion_r629983300
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -91,10 +91,15 @@ case class AdaptiveSparkPlanExec(
DisableUnnecessaryBucketedScan
) ++ context.session.sessionState.queryStagePrepRules
+ @transient private val initialPlan = context.session.withActive {
+ applyPhysicalRules(
+ inputPlan, queryStagePreparationRules, Some((planChangeLogger, "AQE
Preparations")))
+ }
+
// A list of physical optimizer rules to be applied to a new stage before
its execution. These
// optimizations should be stage-independent.
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
- PlanAdaptiveDynamicPruningFilters(context.stageCache),
+ PlanAdaptiveDynamicPruningFilters(initialPlan),
Review comment:
I think it's better to pass `this` as the root plan.
`AdaptiveSparkPlanExec` keeps changing when more and more query stages are
completed. So it's better that `PlanAdaptiveDynamicPruningFilters` always look
at the latest plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
