cloud-fan commented on a change in pull request #32474:
URL: https://github.com/apache/spark/pull/32474#discussion_r630684354
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -147,30 +149,11 @@ trait InvokeLike extends Expression with NonSQLExpression
{
}
final def findMethod(cls: Class[_], functionName: String, argClasses:
Seq[Class[_]]): Method = {
- // Looking with function name + argument classes first.
- try {
- cls.getMethod(functionName, argClasses: _*)
- } catch {
- case _: NoSuchMethodException =>
- // For some cases, e.g. arg class is Object, `getMethod` cannot find
the method.
- // We look at function name + argument length
- val m = cls.getMethods.filter { m =>
- m.getName == functionName && m.getParameterCount == arguments.length
- }
- if (m.isEmpty) {
- sys.error(s"Couldn't find $functionName on $cls")
- } else if (m.length > 1) {
- // More than one matched method signature. Exclude synthetic one,
e.g. generic one.
- val realMethods = m.filter(!_.isSynthetic)
- if (realMethods.length > 1) {
- // Ambiguous case, we don't know which method to choose, just fail
it.
- sys.error(s"Found ${realMethods.length} $functionName on $cls")
- } else {
- realMethods.head
- }
- } else {
- m.head
- }
+ val method = MethodUtils.getMatchingAccessibleMethod(cls, functionName,
argClasses: _*)
+ if (method == null) {
+ sys.error(s"Couldn't find $functionName on $cls")
Review comment:
shall we throw an exception to only fail the query, instead of sys.error
which crashes the driver JVM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
