Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5680#discussion_r29453720
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingJobProgressListener.scala
---
@@ -70,9 +70,8 @@ private[streaming] class
StreamingJobProgressListener(ssc: StreamingContext)
runningBatchInfos(batchStarted.batchInfo.batchTime) =
batchStarted.batchInfo
waitingBatchInfos.remove(batchStarted.batchInfo.batchTime)
- batchStarted.batchInfo.receivedBlockInfo.foreach { case (_, infos) =>
- totalReceivedRecords += infos.map(_.numRecords).sum
- }
+ // TODO. this should be fixed when input stream is not receiver based
stream.
+ totalReceivedRecords +=
batchStarted.batchInfo.streamIdToNumRecords.values.sum
--- End diff --
Yes we need to. Receiver or not, all the data has been received by the
system.
On Apr 30, 2015 1:10 AM, "Saisai Shao" <[email protected]> wrote:
> In
>
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingJobProgressListener.scala
> <https://github.com/apache/spark/pull/5680#discussion_r29410293>:
>
> > @@ -70,9 +70,8 @@ private[streaming] class
StreamingJobProgressListener(ssc: StreamingContext)
> > runningBatchInfos(batchStarted.batchInfo.batchTime) =
batchStarted.batchInfo
> > waitingBatchInfos.remove(batchStarted.batchInfo.batchTime)
> >
> > - batchStarted.batchInfo.receivedBlockInfo.foreach { case (_, infos)
=>
> > - totalReceivedRecords += infos.map(_.numRecords).sum
> > - }
> > + // TODO. this should be fixed when input stream is not receiver
based stream.
> > + totalReceivedRecords +=
batchStarted.batchInfo.streamIdToNumRecords.values.sum
>
> Yes, will do. Also have one concern, if the batchStarted is not a
> receiver-based batchInfo, so do we need to count this records into
> totalReceivedRecords when batch is just started.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/5680/files#r29410293>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
