dongjoon-hyun commented on a change in pull request #32518:
URL: https://github.com/apache/spark/pull/32518#discussion_r631119466



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -396,6 +396,8 @@ class SparkContext(config: SparkConf) extends Logging {
     if (!_conf.contains("spark.app.name")) {
       throw new SparkException("An application name must be set in your 
configuration")
     }
+    // This should be set as early as possible.
+    SparkContext.fillMissingMagicCommitterConfsIfNeeded(_conf)

Review comment:
       Yes, it's possible to handle there for SparkSubmit command parameters, 
however Hadoop configurations also can be handed over to `SparkSession` inside 
Spark Apps after Spark submits.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to