dongjoon-hyun commented on a change in pull request #32520:
URL: https://github.com/apache/spark/pull/32520#discussion_r631160095
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
+ // Since `tpcdsQueriesV2_7_0` has almost the same queries with these oens
below,
+ // we skip them in the TPCDS-related tests.
Review comment:
Well, this hides the previous reasoning. I believe it's worth to keep
SPARK-35327 comment explicitly.
```
SPARK-35327: Filters out the TPC-DS queries that can cause flaky test results
```
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
+ // Since `tpcdsQueriesV2_7_0` has almost the same queries with these oens
below,
+ // we skip them in the TPCDS-related tests.
Review comment:
This hides the previous reasoning. I believe it's worth to keep
SPARK-35327 comment explicitly.
```
SPARK-35327: Filters out the TPC-DS queries that can cause flaky test results
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
