fhygh commented on a change in pull request #32501:
URL: https://github.com/apache/spark/pull/32501#discussion_r631638329
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java
##########
@@ -26,7 +27,7 @@ private static UTF8String trimTrailingSpaces(
UTF8String inputStr, int numChars, int limit) {
int numTailSpacesToTrim = numChars - limit;
UTF8String trimmed = inputStr.trimTrailingSpaces(numTailSpacesToTrim);
- if (trimmed.numChars() > limit) {
+ if (trimmed.numChars() > limit && !SQLConf.get().charVarcharAsString()) {
Review comment:
then do we need update PartitioningUtils.charTypeWriteSideCheck and
PartitioningUtils.varcharTypeWriteSideCheck ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
