srowen commented on a change in pull request #32532:
URL: https://github.com/apache/spark/pull/32532#discussion_r631851246
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -145,12 +151,7 @@ trait InvokeLike extends Expression with NonSQLExpression {
case e: java.lang.reflect.InvocationTargetException if e.getCause !=
null =>
throw e.getCause
}
- val boxedClass = ScalaReflection.typeBoxedJavaMapping.get(dataType)
- if (boxedClass.isDefined) {
- boxedClass.get.cast(ret)
- } else {
- ret
- }
+ boxingFn(ret)
Review comment:
I'm probably missing something dumb here but dataType is an argument to
this method - how can we have one function for it? I don't see where dataType
is available to the trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
