Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5685#discussion_r29465512
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -55,10 +58,14 @@ private[spark] object ClosureCleaner extends Logging {
private def getOuterClasses(obj: AnyRef): List[Class[_]] = {
for (f <- obj.getClass.getDeclaredFields if f.getName == "$outer") {
f.setAccessible(true)
- if (isClosure(f.getType)) {
- return f.getType :: getOuterClasses(f.get(obj))
- } else {
- return f.getType :: Nil // Stop at the first $outer that is not a
closure
+ val outer = f.get(obj)
+ // The outer pointer may be null if we have cleaned this closure
before
+ if (outer != null) {
+ if (isClosure(f.getType)) {
+ return f.getType :: getOuterClasses(f.get(obj))
--- End diff --
"f.get(obj)" -> "outer"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
