dongjoon-hyun commented on a change in pull request #32496:
URL: https://github.com/apache/spark/pull/32496#discussion_r632098934
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
##########
@@ -369,11 +369,25 @@ abstract class HashExpression[E] extends Expression {
protected def genHashBoolean(input: String, result: String): String =
genHashInt(s"$input ? 1 : 0", result)
- protected def genHashFloat(input: String, result: String): String =
- genHashInt(s"Float.floatToIntBits($input)", result)
+ protected def genHashFloat(input: String, result: String): String = {
+ s"""
+ |if($input == -0.0f) {
+ | ${genHashInt(s"Float.floatToIntBits(0.0f)", result)}
+ |} else {
+ | ${genHashInt(s"Float.floatToIntBits($input)", result)}
+ |}
+ """.stripMargin
+ }
- protected def genHashDouble(input: String, result: String): String =
- genHashLong(s"Double.doubleToLongBits($input)", result)
+ protected def genHashDouble(input: String, result: String): String = {
+ s"""
+ |if($input == -0.0d) {
+ | ${genHashLong(s"Double.doubleToLongBits(0.0d)", result)}
Review comment:
In this case, `0L`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
