cloud-fan commented on a change in pull request #32501:
URL: https://github.com/apache/spark/pull/32501#discussion_r632281269
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/util/PartitioningUtils.scala
##########
@@ -72,12 +73,20 @@ private[sql] object PartitioningUtils {
private def charTypeWriteSideCheck(inputStr: String, limit: Int): String = {
val toUtf8 = UTF8String.fromString(inputStr)
- CharVarcharCodegenUtils.charTypeWriteSideCheck(toUtf8, limit).toString
+ if (SQLConf.get.charVarcharAsString) {
Review comment:
can we move the check to `normalizePartitionSpec`?
```
val normalizedVal = if (SQLConf.get.charVarcharAsString) value else
normalizedFiled.dataType match {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
