Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5814#issuecomment-97963705
When I ran my one of my aggregation hash map benchmarks with
`-XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining` enabled it looks like the
static methods in the `UNSAFE` facade are being inlined. I grepped the output
for "org.apache.spark.unsafe.PlatformDependent\$UNSAFE::" and it looks like all
call sites are being inlined. @rxin, is this a methodologically sound way to
check that the facade didn't add any overhead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
