HyukjinKwon commented on a change in pull request #32555:
URL: https://github.com/apache/spark/pull/32555#discussion_r633024476
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -482,10 +482,22 @@ def show(self, n=20, truncate=True, vertical=False):
age | 5
name | Bob
"""
+
+ if not isinstance(n, int) or isinstance(n, bool):
+ raise TypeError(f'Parameter `n` (number of rows) must be an int')
+
+ if not isinstance(vertical, bool):
+ raise TypeError(f'Parameter `vertical` must be a bool')
+
if isinstance(truncate, bool) and truncate:
print(self._jdf.showString(n, 20, vertical))
else:
- print(self._jdf.showString(n, int(truncate), vertical))
+ try:
+ int_truncate = int(truncate)
+ print(self._jdf.showString(n, int_truncate, vertical))
Review comment:
I think you should pull this call out, and don't combine with parameter
validation logic together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
