Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5432#discussion_r29473085
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ---
    @@ -96,33 +99,39 @@ class FsHistoryProviderSuite extends FunSuite with 
BeforeAndAfter with Matchers
         oldAppIncomplete.mkdir()
         createEmptyFile(new File(oldAppIncomplete, 
provider.SPARK_VERSION_PREFIX + "1.0"))
         writeFile(new File(oldAppIncomplete, provider.LOG_PREFIX + "1"), 
false, None,
    -      SparkListenerApplicationStart("old-app-incomplete", None, 2L, "test")
    +      SparkListenerApplicationStart("old-app-incomplete", None, 2L, 
"test", None)
           )
     
         // Force a reload of data from the log directory, and check that both 
logs are loaded.
         // Take the opportunity to check that the offset checks work as 
expected.
    -    provider.checkForLogs()
    +    updateAndCheck(provider) { list =>
    +      list.size should be (5)
    +      list.count(_.attempts.head.completed) should be (3)
    +
    +      def makeAppInfo(id: String, name: String, start: Long, end: Long, 
lastMod: Long,
    +        user: String, completed: Boolean): ApplicationHistoryInfo = {
    --- End diff --
    
    can you format this properly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to