Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-97975817
Definitely do not change the equality function for `AttributeReference`. I
did this in an early version of catalyst and the result can be quite confusing.
`equals()` should always be exact and consider _all_ properties of a case
class.
Instead, use an `AttributeSet` whenever you are looking for reference
`equals` or `contains` operations. Really it would be awesome if we could add
a linter rule that warned for `Seq/Set[Attribute].contains()`, since this is
often incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
