cloud-fan commented on a change in pull request #32411:
URL: https://github.com/apache/spark/pull/32411#discussion_r633635249



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
##########
@@ -96,4 +99,19 @@ object DataWritingCommand {
       sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY),
       metrics.values.toSeq)
   }
+
+  def assertEmptyRootPath(tablePath: URI, saveMode: SaveMode, hadoopConf: 
Configuration) {
+    if (saveMode != SaveMode.Overwrite && 
!SQLConf.get.allowNonEmptyLocationInCTAS) {

Review comment:
       Can we add a bit more comment to explain the save mode here? For SQL 
CTAS, the mode is always append?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to