cloud-fan commented on a change in pull request #32503:
URL: https://github.com/apache/spark/pull/32503#discussion_r633564297
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -836,15 +836,7 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
val outer = a.collect { case OuterReference(e) => e.toAttribute }
val local = a.references -- outer
if (local.nonEmpty) {
- val msg =
- s"""
- |Found an aggregate expression in a correlated predicate that
has both
- |outer and local references, which is not supported yet.
- |Aggregate expression:
${SubExprUtils.stripOuterReference(a).sql},
- |Outer references: ${outer.map(_.sql).mkString(", ")},
- |Local references: ${local.map(_.sql).mkString(", ")}.
- """.stripMargin.replace("\n", " ").trim()
- failAnalysis(msg)
+ throw QueryCompilationErrors.mixedRefsInAggFunc(a.sql)
Review comment:
I did it intentionally so that people can see the outer reference
directly like `min((outer(t1.t1a) + t2.t2a))`
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
##########
@@ -189,17 +189,22 @@ object SubExprUtils extends PredicateHelper {
*/
def getOuterReferences(expr: Expression): Seq[Expression] = {
val outerExpressions = ArrayBuffer.empty[Expression]
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
