otterc commented on a change in pull request #32007:
URL: https://github.com/apache/spark/pull/32007#discussion_r633744774
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -117,7 +116,7 @@ public ShuffleIndexInformation load(File file) throws
IOException {
private AppShufflePartitionInfo getOrCreateAppShufflePartitionInfo(
AppShuffleId appShuffleId,
int reduceId) {
- File dataFile = getMergedShuffleDataFile(appShuffleId, reduceId);
+ File dataFile = getMergedShuffleDataFile(appShuffleId.appId,
appShuffleId.shuffleId, reduceId);
Review comment:
When the server receives a pushBlock message then there are 2 cases:
1. It belongs to previous attempt: in this case it needs to ignore that
message. If we don't then it will corrupt the file here.
2. It belongs to latest attempt: in this case we should continue merging
Need to handle case (1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
