Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5784#discussion_r29476383
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
    @@ -280,20 +283,10 @@ private[spark] class MemoryStore(blockManager: 
BlockManager, maxMemory: Long)
               val currentSize = vector.estimateSize()
               if (currentSize >= memoryThreshold) {
                 val amountToRequest = (currentSize * memoryGrowthFactor - 
memoryThreshold).toLong
    -            // Hold the accounting lock, in case another thread 
concurrently puts a block that
    -            // takes up the unrolling space we just ensured here
    --- End diff --
    
    move this comment into the new method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to