dongjoon-hyun commented on a change in pull request #32577:
URL: https://github.com/apache/spark/pull/32577#discussion_r634025398



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -638,6 +645,8 @@ case class InSet(child: Expression, hset: Set[Any]) extends 
UnaryExpression with
     val valueSQL = child.sql
     val listSQL = hset.toSeq
       .map(elem => Literal(elem, child.dataType).sql)
+      // Sort elements for deterministic behaviours
+      .sorted

Review comment:
       Ditto. Can we do `sort` first?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to