sunchao commented on a change in pull request #32553:
URL: https://github.com/apache/spark/pull/32553#discussion_r634030313
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -50,7 +50,14 @@ trait InvokeLike extends Expression with NonSQLExpression {
def propagateNull: Boolean
- protected lazy val needNullCheck: Boolean = propagateNull &&
arguments.exists(_.nullable)
+ def propagateNullForPrimitive: Boolean
Review comment:
OK. Let me remove the flag then, and add an extra comment to
`propagateNull`.
One issue with this approach is that it only applies to the magic method
path, while for `produceResult` users will need to handle the null primitive
values explicitly. I think we'll need to document this more carefully,
otherwise it could cause confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
