Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/649#discussion_r12294097
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnableUtil.scala
 ---
    @@ -56,10 +56,18 @@ trait ExecutorRunnableUtil extends Logging {
           JAVA_OPTS += opts
         }
     
    -    JAVA_OPTS += " -Djava.io.tmpdir=" +
    -      new Path(Environment.PWD.$(), 
YarnConfiguration.DEFAULT_CONTAINER_TEMP_DIR) + " "
    +    JAVA_OPTS += "-Djava.io.tmpdir=" +
    +      new Path(Environment.PWD.$(), 
YarnConfiguration.DEFAULT_CONTAINER_TEMP_DIR)
         JAVA_OPTS += ClientBase.getLog4jConfiguration(localResources)
     
    +    // This is needed for the authentication configs because the Executor 
has to know whether
    +    // to use authentication before it registers with the Scheduler.
    +    // We should see if it makes sense to only do for the auth settings, 
but for now just do them
    +    // all.
    --- End diff --
    
    small nit: Could you line these comments up?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to