cloud-fan commented on pull request #32511: URL: https://github.com/apache/spark/pull/32511#issuecomment-843880234
We may need to rethink the explain mode. Currently we have ``` SimpleMode ExtendedMode CodegenMode CostMode FormattedMode ``` I feel like the formatted mode does not play well here. It's a new way to print the query plan, but it should be orthogonal to explain mode, like simple vs extended, like additional codegen/cost info. I propose to have a config to switch between the old and new format, and deprecate `FormattedMode`. We can also refactor the code to use visitor pattern to generate the tree string, so that it's easier to add new information such as codegen and cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
