vinodkc commented on a change in pull request #32411:
URL: https://github.com/apache/spark/pull/32411#discussion_r635076302
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala
##########
@@ -235,10 +235,10 @@ class CreateTableAsSelectSuite extends DataSourceTest
with SharedSparkSession {
}
test("create table using as select - with overridden max number of buckets")
{
- def createTableSql(numBuckets: Int): String =
+ def createTableSql(tablePath: String, numBuckets: Int): String =
s"""
|CREATE TABLE t USING PARQUET
- |OPTIONS (PATH '${path.toURI}')
+ |OPTIONS (PATH '$tablePath')
Review comment:
Yes, in this test case, the function `createTableSql ` will be called
twice inside `Seq(100001, maxNrBuckets).foreach(...)`. As this PR doesn't allow
CTAS with a non-empty location, the second call of `createTableSql` will fail
if the same `path` used. That is why for each iteration a new table location is
created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
