cfmcgrady commented on a change in pull request #32488:
URL: https://github.com/apache/spark/pull/32488#discussion_r635192912
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala
##########
@@ -121,6 +129,24 @@ object UnwrapCastInBinaryComparison extends
Rule[LogicalPlan] {
if canImplicitlyCast(fromExp, toType, literalType) =>
simplifyNumericComparison(be, fromExp, toType, value)
+ case in @ In(Cast(fromExp, toType: NumericType, _), list)
+ if list.forall(v =>
+ v.isInstanceOf[Literal] && canImplicitlyCast(fromExp, toType,
v.dataType)
Review comment:
Sorry, made some mistake. We should check the `v.dataType` in `in.list`,
due to we may get a `fromExpr` that is not in `NumericType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
