Kimahriman commented on a change in pull request #32559:
URL: https://github.com/apache/spark/pull/32559#discussion_r635643124
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2861,6 +2861,25 @@ class DataFrameSuite extends QueryTest
checkAnswer(result, Row(0, 0, 0, 0, 100))
}
}
+
+ test("SPARK-35410: SubExpr elimination should not include redundant child
exprs " +
+ "for conditional expressions") {
+ val accum = sparkContext.longAccumulator("call")
+ val simpleUDF = udf((s: String) => {
+ accum.add(1)
+ s
+ })
+ val df1 = spark.range(5).select(when(functions.length(simpleUDF($"id")) >
0,
Review comment:
I think the fix for https://issues.apache.org/jira/browse/SPARK-35449
will break this, since it's really a "bug" that the case value is included in
subexpression resolution without an else value. Not a huge deal, I can try to
fix in my follow up once this is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
