HyukjinKwon commented on a change in pull request #32161:
URL: https://github.com/apache/spark/pull/32161#discussion_r635789667



##########
File path: python/pyspark/sql/readwriter.py
##########
@@ -1259,12 +1218,15 @@ def parquet(self, path, mode=None, partitionBy=None, 
compression=None):
                 exists.
         partitionBy : str or list, optional
             names of partitioning columns
-        compression : str, optional
-            compression codec to use when saving to file. This can be one of 
the
-            known case-insensitive shorten names (none, uncompressed, snappy, 
gzip,
-            lzo, brotli, lz4, and zstd). This will override
-            ``spark.sql.parquet.compression.codec``. If None is set, it uses 
the
-            value specified in ``spark.sql.parquet.compression.codec``.
+
+        Other Parameters
+        ----------------
+        Extra options
+            For the extra options, refer to
+            `Data Source Option 
<https://spark.apache.org/docs/latest/sql-data-sources-parquet.html#data-source-option>`_
  # noqa
+            and
+            `Generic File Source Options 
<https://spark.apache.org/docs/latest/sql-data-sources-generic-options.html`>_  
# noqa

Review comment:
       Here you linked generic option but you didn't at 
https://github.com/apache/spark/pull/32161/files#diff-e283917d906671f2e032d1debe091cb13038440e2daa24b982ce5d486d96b0d7R863-R866




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to