ulysses-you commented on a change in pull request #32602:
URL: https://github.com/apache/spark/pull/32602#discussion_r635897104
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -59,19 +66,33 @@ object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
case Some(count) => hasRow == (count > 0)
case _ => false
}
+
+ case LocalRelation(_, data, isStreaming) if !isStreaming =>
Review comment:
sgtm, and just find a exists rule `PropagateEmptyRelation`.
How about this updating ?
* Add a rule `ConvertToLocalRelation` to turn empty query stage into empty
LocalRelation
* Make `PropagateEmptyRelation` appears in AQE optimizer
* Reduce `EliminateUnnecessaryJoin` to only handle naaj/semi/anti joins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
