HyukjinKwon commented on a change in pull request #32586:
URL: https://github.com/apache/spark/pull/32586#discussion_r635963399
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
##########
@@ -167,7 +167,28 @@ class EquivalentExpressions {
* Returns all the equivalent sets of expressions.
*/
def getAllEquivalentExprs: Seq[Seq[Expression]] = {
- equivalenceMap.values.map(_.toSeq).toSeq
+ equivalenceMap.values.map(_.toSeq).toSeq.sortBy(_.head)(new
ExpressionContainmentOrdering)
+ }
+
+ /**
+ * Orders [Expression] by parent/child relations. The child expression is
smaller
Review comment:
```suggestion
* Orders [[Expression]] by parent/child relations. The child expression
is smaller
```
or
```suggestion
* Orders `Expression` by parent/child relations. The child expression is
smaller
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
