srowen commented on a change in pull request #32534:
URL: https://github.com/apache/spark/pull/32534#discussion_r636122066
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -385,9 +390,33 @@ private[spark] class MemoryStore(
}
}
+ def manual_close[T <: MemoryEntry[_]](entry: T): T = {
Review comment:
Nit: `manualClose`
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -385,9 +390,33 @@ private[spark] class MemoryStore(
}
}
+ def manual_close[T <: MemoryEntry[_]](entry: T): T = {
+ val entryManualCloseTasks = Future {
+ entry match {
+ case e: DeserializedMemoryEntry[_] => e.value.foreach {
+ case o: AutoCloseable =>
+ try {
+ o.close
+ } catch {
+ case NonFatal(e) =>
+ logWarning(s"Got NonFatal exception during remove")
+ }
+ case _ =>
+ }
+ case _ =>
+ }
+ }
+ entryManualCloseTasks.onComplete {
Review comment:
This callback will throw an exception but not sure what that will do -
probably just get logged. I think it's reasonable to log the error as a warning
and continue - not being able to close is "OK" and shouldn't stop anything else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
