xuechendi commented on a change in pull request #32534:
URL: https://github.com/apache/spark/pull/32534#discussion_r636177473
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -385,9 +390,33 @@ private[spark] class MemoryStore(
}
}
+ def manual_close[T <: MemoryEntry[_]](entry: T): T = {
+ val entryManualCloseTasks = Future {
+ entry match {
+ case e: DeserializedMemoryEntry[_] => e.value.foreach {
+ case o: AutoCloseable =>
+ try {
+ o.close
+ } catch {
+ case NonFatal(e) =>
+ logWarning(s"Got NonFatal exception during remove")
+ }
+ case _ =>
+ }
+ case _ =>
+ }
+ }
+ entryManualCloseTasks.onComplete {
Review comment:
@srowen , because NonFatal exception has been captured and logged in
above try/catch, so I think only fail it will catch on this onComplete callback
is Fatal exception, that is why I continue to throw here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
