dongjoon-hyun commented on a change in pull request #32610:
URL: https://github.com/apache/spark/pull/32610#discussion_r636616275
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -250,11 +250,21 @@ private[spark] object Config extends Logging {
.stringConf
.createOptional
+ private val podConfValidator =
+
"^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$".r.pattern
+
val KUBERNETES_EXECUTOR_POD_NAME_PREFIX =
ConfigBuilder("spark.kubernetes.executor.podNamePrefix")
- .doc("Prefix to use in front of the executor pod names.")
+ .doc("Prefix to use in front of the executor pod names. Note that pod
names must consist" +
+ " of lower case alphanumeric characters, '-' or '.', and must start
and end with an" +
+ " alphanumeric character (e.g. 'example.com', regex used for
validation is:" +
+ s" ${podConfValidator.toString}")
Review comment:
+1 for following their implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
