xinrong-databricks commented on a change in pull request #32611:
URL: https://github.com/apache/spark/pull/32611#discussion_r637301587
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_date_ops.py
##########
@@ -60,7 +61,9 @@ def test_sub(self):
with option_context("compute.ops_on_diff_frames", True):
for pser, psser in self.pser_psser_pairs:
if isinstance(psser.spark.data_type, DateType):
- self.assert_eq((self.pser - pser).dt.days, (self.psser -
psser).sort_index())
+ if LooseVersion(pd.__version__) >= LooseVersion("0.24.2"):
+ self.assert_eq(
+ (self.pser - pser).dt.days, (self.psser -
psser).sort_index())
Review comment:
It raises weird TypeError for pandas in the `else` case, as
https://github.com/databricks/koalas/runs/2568962950.
No, the change is not related to this PR. Let me remove it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
