viirya commented on a change in pull request #32594:
URL: https://github.com/apache/spark/pull/32594#discussion_r637667408
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -96,10 +96,9 @@ case class AdaptiveSparkPlanExec(
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
PlanAdaptiveDynamicPruningFilters(this),
ReuseAdaptiveSubquery(context.subqueryCache),
- CoalesceShufflePartitions(context.session),
- // The following two rules need to make use of
'CustomShuffleReaderExec.partitionSpecs'
- // added by `CoalesceShufflePartitions`. So they must be executed after it.
+ // Skew join does not handle `CustomShuffleReader` so needs to be applied
first.
OptimizeSkewedJoin,
+ CoalesceShufflePartitions(context.session),
OptimizeLocalShuffleReader
Review comment:
As `OptimizeLocalShuffleReader` still handles `CustomShuffleReaderExec`,
we should keep the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
