Ngone51 commented on a change in pull request #32007:
URL: https://github.com/apache/spark/pull/32007#discussion_r637976278



##########
File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
##########
@@ -190,3 +295,9 @@ private[spark] class DiskBlockManager(conf: SparkConf, 
deleteFilesOnStop: Boolea
     }
   }
 }
+
+private[spark] object DiskBlockManager {
+  private[spark] val MERGE_DIRECTORY = "merge_directory"
+  private[spark] val MERGE_DIR_KEY = "mergeDir"
+  private[spark] val ATTEMPT_ID_KEY = "attemptId"

Review comment:
       Do we have a helper class or object for push-based shuffle? It would be 
better to put these fields there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to